Make CertFile and KeyFile relative to CustomPath#9868
Merged
Conversation
zeripath
added
type/bug
pr/breaking
The current code will absolute CertFile and KeyFile against the current working directory. This is quite unexpected for users. This code makes relative paths absolute against the CustomPath. Fix go-gitea#4196
Contributor
Author
|
I've also improved the error handling as |
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Jan 19, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #9868 +/- ##
=========================================
Coverage ? 42.31%
=========================================
Files ? 604
Lines ? 79171
Branches ? 0
=========================================
Hits ? 33500
Misses ? 41541
Partials ? 4130
Continue to review full report at Codecov.
|
Member
Merged
Contributor
Author
|
yeah I'll backport the whole thing. |
Member
|
@zeripath but this is kind/breaking ?!? |
Contributor
Author
|
Yeah but I think it's broken already... |
lunny
reviewed
Jan 19, 2020
zeripath
commented
Jan 19, 2020
guillep2k
reviewed
Jan 19, 2020
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
guillep2k
approved these changes
Jan 19, 2020
GiteaBot
added
lgtm/done
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 19, 2020
* Make CertFile and KeyFile relative to CustomPath The current code will absolute CertFile and KeyFile against the current working directory. This is quite unexpected for users. This code makes relative paths absolute against the CustomPath. Fix go-gitea#4196 * Improve error reporting when reading certificates * Apply suggestions from code review Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
zeripath
added a commit
that referenced
this pull request
Jan 19, 2020
* Make CertFile and KeyFile relative to CustomPath The current code will absolute CertFile and KeyFile against the current working directory. This is quite unexpected for users. This code makes relative paths absolute against the CustomPath. Fix #4196 * Improve error reporting when reading certificates * Apply suggestions from code review Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code will absolute CertFile and KeyFile against the current working directory. This is quite unexpected for users. This code makes relative paths absolute against the CustomPath.
Fix #4196